siddhantsangwan commented on code in PR #9228:
URL: https://github.com/apache/ozone/pull/9228#discussion_r2485606818
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerStateManagerImpl.java:
##########
@@ -356,26 +356,51 @@ public boolean contains(ContainerID id) {
public void updateContainerState(final HddsProtos.ContainerID containerID,
final LifeCycleEvent event)
throws IOException, InvalidStateTransitionException {
+ final ContainerID id = ContainerID.getFromProtobuf(containerID);
+ try (AutoCloseableLock ignored = readLock(id)) {
+ if (containers.contains(id)) {
+ final ContainerInfo containerInfo = containers.getContainerInfo(id);
+ Long currentSequenceId = containerInfo.getSequenceId();
+ // Delegate to @Replicate method with current sequenceId
+ updateContainerStateWithSequenceId(containerID, event,
currentSequenceId);
Review Comment:
We should call the interface method `updateContainerStateWithSequenceId`
instead of the implementation being called here, right? Only then will the
proxy be invoked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
