yandrey321 commented on code in PR #9236:
URL: https://github.com/apache/ozone/pull/9236#discussion_r2486738304
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/service/TestDirectoryDeletingServiceWithFSO.java:
##########
@@ -657,7 +657,11 @@ public void
testAOSKeyDeletingWithSnapshotCreateParallelExecution()
store.deleteSnapshot(testVolumeName, testBucketName, snap2);
service.runPeriodicalTaskNow();
store.deleteSnapshot(testVolumeName, testBucketName, snap1);
+ cluster.getOzoneManager().awaitDoubleBufferFlush();
Review Comment:
should we have a timeout for await()/wait() calls?
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestKeyDeletingService.java:
##########
@@ -1123,9 +1125,16 @@ void testPurgeKeysRequestBatching() throws Exception {
testKds.resume();
- // Manually trigger the KeyDeletingService to run its task immediately.
- // This will initiate the purge requests to Ratis.
- testKds.runPeriodicalTaskNow();
+ // Deterministically drain: keep running the service until it reports
+ // all keys from this test have been reclaimed.
+ GenericTestUtils.waitFor(() -> {
Review Comment:
what is the typical wait time here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
