yandrey321 commented on code in PR #9215:
URL: https://github.com/apache/ozone/pull/9215#discussion_r2487453260
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/ReconstructECContainersCommandHandler.java:
##########
@@ -55,14 +54,11 @@ public void handle(SCMCommand<?> command, OzoneContainer
container,
new ECReconstructionCommandInfo(ecContainersCommand);
ECReconstructionCoordinatorTask task = new ECReconstructionCoordinatorTask(
coordinator, reconstructionCommandInfo);
- if (this.metricsName == null) {
- this.metricsName = task.getMetricName();
- }
this.supervisor.addTask(task);
}
public String getMetricsName() {
- return this.metricsName;
+ return ECReconstructionCoordinatorTask.METRIC_NAME;
Review Comment:
return task.getMetricName(); ?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/ReconcileContainerCommandHandler.java:
##########
@@ -58,29 +54,25 @@ public SCMCommandProto.Type getCommandType() {
@Override
public int getQueuedCount() {
- return this.metricsName == null ? 0 : (int) this.supervisor
- .getReplicationQueuedCount(metricsName);
+ return (int)
this.supervisor.getReplicationQueuedCount(ReconcileContainerTask.METRIC_NAME);
Review Comment:
why specific task type is hardcoded here instead of task.getMetricName() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
