linyiqun commented on a change in pull request #2228:
URL: https://github.com/apache/ozone/pull/2228#discussion_r630298237
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3MultipartUploadCommitPartRequestWithFSO.java
##########
@@ -66,13 +66,20 @@ protected void addKeyToOpenKeyTable(String volumeName,
String bucketName,
fileName, omKeyInfo, clientID, txnLogId, omMetadataManager);
}
- protected String getMultipartKey(String volumeName, String bucketName,
+ protected String getMultipartOpenKey(String volumeName, String bucketName,
Review comment:
Same comment for adding `@Override`.
@rakeshadr , can you check similar other places and fix them all in
**WithFSO.class? As currently most of logic can be reused, it will be better to
add `override`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
