ivandika3 commented on code in PR #9255:
URL: https://github.com/apache/ozone/pull/9255#discussion_r2501407263


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLifecycleConfiguration.java:
##########
@@ -230,6 +245,7 @@ public static OmLifecycleConfiguration getFromProtobuf(
   public static class Builder extends WithObjectID.Builder {
     private String volume = "";
     private String bucket = "";
+    private long bucketObjectID = -1L;

Review Comment:
   How about set this to `Long` which defaults to null instead of -1L? If we 
forget to set this in some places, the object ID might be wrongly set to -1 and 
lifecycle configuration might not work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to