jojochuang commented on code in PR #9132:
URL: https://github.com/apache/ozone/pull/9132#discussion_r2505850871
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -4006,19 +4009,23 @@ TermIndex installCheckpoint(String leaderId,
DBCheckpoint omDBCheckpoint)
throws Exception {
Path checkpointLocation = omDBCheckpoint.getCheckpointLocation();
+ Path checkpointDataDir =
Paths.get(checkpointLocation.getParent().toString(),
+ OM_CHECKPOINT_DATA_DIR);
+ Path omDbPath = Paths.get(checkpointDataDir.toString(), OM_DB_NAME);
TransactionInfo checkpointTrxnInfo = OzoneManagerRatisUtils
- .getTrxnInfoFromCheckpoint(configuration, checkpointLocation);
+ .getTrxnInfoFromCheckpoint(configuration, omDbPath);
LOG.info("Installing checkpoint with OMTransactionInfo {}",
checkpointTrxnInfo);
- return installCheckpoint(leaderId, checkpointLocation, checkpointTrxnInfo);
+ return installCheckpoint(leaderId, checkpointDataDir, checkpointTrxnInfo);
}
- TermIndex installCheckpoint(String leaderId, Path checkpointLocation,
+ TermIndex installCheckpoint(String leaderId, Path checkpointDataDir,
Review Comment:
checkstyle: installCheckpoint() method too long. Opened
https://issues.apache.org/jira/browse/HDDS-13895 to refactor the checkpointing
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
