ptlrs commented on code in PR #9189: URL: https://github.com/apache/ozone/pull/9189#discussion_r2507140840
########## hadoop-ozone/dist/src/shell/conf/om-audit-log4j2.properties: ########## @@ -80,6 +80,7 @@ appender.rolling.policies.time.interval=86400 appender.rolling.policies.size.type=SizeBasedTriggeringPolicy appender.rolling.policies.size.size=64MB appender.rolling.strategy.type=DefaultRolloverStrategy +appender.rolling.strategy.max=2000 Review Comment: Thanks for the review @sumitagrawl. Note that before this PR, we only save 7 files per day. Even though we have seconds in the file name, the rollover period is for `86400 seconds` which is `1 day`. So at any given point we will only have 7 files in a day, unless the process is restarted, in which case we will have `number of restarts * 7` files at most. After this PR, the number of restarts won't matter. We will save 2000 files for OM per day and remove the ambiguity in number of files that are present per day. Estimate of file size: - Writing 20,000 keys to Ozone results in an OM audit log file of ~10MB with 40,000 lines. - Our current max allowed file size is 64MB which after it is rolled-over. - The 64MB file after compression is ~3MB. - For the OM, total size on disk for 2000 files of `each day` will be `~6GB` with around 240 million operations being logged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
