hanishakoneru commented on a change in pull request #2138:
URL: https://github.com/apache/ozone/pull/2138#discussion_r630526952
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -248,6 +249,22 @@ public void onRemoval(
}).build();
}
+ @NotNull
+ @VisibleForTesting
+ protected XceiverClientFactory createXceiverClientFactory(
+ ConfigurationSource configSource,
+ List<X509Certificate> x509Certificates) throws IOException {
+ return new XceiverClientManager(configSource,
+ conf.getObject(XceiverClientManager.ScmClientConfig.class),
Review comment:
Here, configSource = conf. Is there any use case for setting the
ConfigurationSource separately from ScmClientConfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
