aswinshakil commented on code in PR #9275:
URL: https://github.com/apache/ozone/pull/9275#discussion_r2511627176


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -394,6 +395,7 @@ private Optional<PurgePathRequest> prepareDeleteDirRequest(
         keyManager.getPendingDeletionSubDirs(volumeBucketId.getVolumeId(), 
volumeBucketId.getBucketId(),
             pendingDeletedDirInfo, keyInfo -> true, remainingBufLimit);
     List<OmKeyInfo> subDirs = subDirDeleteResult.getKeysToDelete();
+    subDirs.replaceAll(keyInfo -> new 
OmKeyInfo.Builder(keyInfo).setAcls(Collections.emptyList()).build());

Review Comment:
   Can we just do this in `gatherSubPathsWithIterator` so that we can avoid one 
more iteration of creating new objects? 
   Same for the change below. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to