jojochuang commented on code in PR #9235:
URL: https://github.com/apache/ozone/pull/9235#discussion_r2512049831
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestKeyDeletingService.java:
##########
@@ -1254,6 +1260,7 @@ private static boolean assertTableRowCount(long
expectedCount,
LOG.info("{} actual row count={}, expectedCount={}", table.getName(),
count.get(), expectedCount);
});
+ System.out.println("Swaminathan \t" + count.get() + "\t" + expectedCount);
Review Comment:
please fix this
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
Review Comment:
```suggestion
* @param dest destination snapshot
* @param tablesToLookup Set of column-family (table) names to include
when reading SST files; must be non-null.
```
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -622,10 +623,10 @@ private String trimSSTFilename(String filename) {
* @param rocksDB open rocksDB instance.
Review Comment:
```suggestion
* @param rocksDB open rocksDB instance.
* @param tableFilter set of column-family/table names to include when
collecting live SSTs.
```
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/StringUtils.java:
##########
@@ -123,4 +123,11 @@ public static String
getLexicographicallyHigherString(String val) {
charVal[lastIdx] += 1;
return String.valueOf(charVal);
}
+
+ public static String getFirstNChars(String str, int n) {
+ if (str == null || str.length() < n) {
+ return str;
+ }
+ return str.substring(0, n);
+ }
Review Comment:
this is fine.
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
Review Comment:
```suggestion
* @param dest destination snapshot
* @param tablesToLookup set of table (column family) names used to
restrict which SST files are
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
