swamirishi commented on code in PR #9270:
URL: https://github.com/apache/ozone/pull/9270#discussion_r2514234568
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -460,9 +470,51 @@ private OzoneManagerProtocolProtos.PurgePathRequest
wrapPurgeRequest(
return purgePathsRequest.build();
}
- private OzoneManagerProtocolProtos.OMResponse
submitPurgePaths(List<PurgePathRequest> requests,
+ private List<OzoneManagerProtocolProtos.OMResponse>
submitPurgePathsWithBatching(List<PurgePathRequest> requests,
String snapTableKey, UUID expectedPreviousSnapshotId,
Map<VolumeBucketId, BucketNameInfo> bucketNameInfoMap)
throws InterruptedException {
+
+ List<OzoneManagerProtocolProtos.OMResponse> responses = new ArrayList<>();
+ List<PurgePathRequest> purgePathRequestBatch = new ArrayList<>();
+ int batchBytes = 0;
Review Comment:
IMO we shouldn't make it long since the ratis byte limit would always be in
an int value. I don't think we would ever set this value in gigs and we should
not allow it as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
