ChenSammi commented on code in PR #9214:
URL: https://github.com/apache/ozone/pull/9214#discussion_r2522822712
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneObjInfo.java:
##########
@@ -237,4 +238,27 @@ public OzoneObjInfo build() {
name, ozonePrefixPath);
}
}
+
+ @Override
+ public boolean equals(
+ Object o
+ ) {
Review Comment:
I would like to introduce the code style that followed in Ozone. It's
recommend to have content
in one line as much as possible, also the ") {" is at the same line as
function statement if possible.
`public boolean equals(Object o) {`
Same suggestion for the rest all function declaration.
And statement like following
```
final AssumeRoleRequest assumeRoleRequest1 = new AssumeRoleRequest(
"host",
null,
ugi,
"roleA",
grants
);
```
is recommended to change to
```
final AssumeRoleRequest assumeRoleRequest1 = new AssumeRoleRequest(
"host", null, ugi, "roleA", grants);
```
to have a consistent code style across Ozone modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
