hevinhsu commented on PR #9294: URL: https://github.com/apache/ozone/pull/9294#issuecomment-3531828192
#### Investigation: why aws-sdk-ruby test still fails In the AWS documentation — for example, [IAM](https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_sigv-create-signed-request.html), [S3 query parameter](https://docs.aws.amazon.com/AmazonS3/latest/API/sigv4-query-string-auth.html) and [S3 Signature Calculations for the Authorization Header](https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html) — it is stated that all `x-amz-*` headers must be included in the signature calculation. However, in the [Mint Ruby testcase](https://github.com/minio/mint/blob/master/run/core/aws-sdk-ruby/aws-stub-tests.rb#L730-L732),it appears that the `x-amz-acl` header is **not** added to the signature calculation. As a result, the test currently fails. In the [MinIO implementation](https://github.com/minio/minio/blob/master/cmd/signature-v4.go#L211), only the `x-amz-meta-*` headers are validated to exist in the [signedHeaders](https://github.com/minio/minio/blob/master/cmd/signature-v4.go#L233). Therefore, the Ruby test — which does not include `x-amz-acl` in the signed headers — can still pass successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
