chungen0126 commented on code in PR #9286:
URL: https://github.com/apache/ozone/pull/9286#discussion_r2529727333
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -363,6 +367,15 @@ public Response listMultipartUploads(
maxUploads = Math.min(maxUploads, 1000);
}
+ // The valid encodingType Values is "url"
+ if (encodingType != null && !encodingType.equals(ENCODING_TYPE)) {
+ throw S3ErrorTable.newError(S3ErrorTable.INVALID_ARGUMENT, encodingType);
+ }
+
+ if (prefix == null) {
+ prefix = "";
+ }
Review Comment:
There are duplicate lines in the above function where we call
listMultipartUploads. Could we move them before this call instead of using them
repeatedly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
