adoroszlai commented on code in PR #9301:
URL: https://github.com/apache/ozone/pull/9301#discussion_r2534673177
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/bucket/TestOMBucketCreateRequest.java:
##########
@@ -330,8 +332,10 @@ private void rejectBucketCreationHelper(String volumeName,
String bucketName) {
Throwable e = assertThrows(OMException.class, () ->
doPreExecute(volumeName, bucketName));
- assertEquals(e.getMessage(), "Invalid bucket name: " + bucketName);
- }
+ assertEquals(
+ "INVALID_BUCKET_NAME bucket name has an unsupported character : _",
+ OMException.ResultCodes.INVALID_BUCKET_NAME + " " + e.getMessage()
+ ); }
Review Comment:
nit:
- no need to prepend `INVALID_BUCKET_NAME` to the messages
- unnecessary odd whitespace change
```suggestion
"bucket name has an unsupported character : _",
e.getMessage()
);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
