swamirishi commented on code in PR #9268:
URL: https://github.com/apache/ozone/pull/9268#discussion_r2535757801
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDiffUtils.java:
##########
@@ -54,40 +48,32 @@ public static boolean isKeyWithPrefixPresent(String
prefixForColumnFamily,
&& prefixForColumnFamily.compareTo(endKeyPrefix) <= 0;
}
- public static void filterRelevantSstFiles(Set<String> inputFiles,
- TablePrefixInfo tablePrefixInfo,
- Set<String> columnFamiliesToLookup,
- ManagedRocksDB... dbs) {
- filterRelevantSstFiles(inputFiles, tablePrefixInfo,
Collections.emptyMap(), columnFamiliesToLookup, dbs);
+ /**
+ * Filter sst files based on prefixes.
+ */
+ public static <T> Map<T, SstFileInfo> filterRelevantSstFiles(Map<T,
SstFileInfo> inputFiles,
Review Comment:
changed the variable name and added a note in the javadoc as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
