sumitagrawl commented on code in PR #9185:
URL: https://github.com/apache/ozone/pull/9185#discussion_r2536383793
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfig.java:
##########
@@ -138,6 +139,15 @@ public class ScmConfig extends ReconfigurableConfig {
)
private int transactionToDNsCommitMapLimit = 5000000;
+ @Config(key = "hdds.scm.block.deleting.service.scheduling.mode",
+ defaultValue = "FIXED_RATE",
+ type = ConfigType.STRING,
+ tags = { ConfigTag.SCM, ConfigTag.DELETION },
+ description = "Scheduling mode for the block deleting service. For
detailed, " +
+ "see org.apache.hadoop.hdds.utils.SchedulingMode"
+ )
+ private String blockDeletingServiceSchedulingMode =
SchedulingMode.FIXED_RATE.name();
Review Comment:
@xichen01 fixed_delay can make service run continuously if previous
iteration is taking time. This is useful for case to quickly clear-up blocks
running continuously, as wait time can reduce to 1 milli-second for iteration
taking time.
But this is not solving problem as mentioned in JIRA as can create
continuous running for large block deletion as fixed delay is just 1
milli-second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
