Gargi-jais11 commented on code in PR #9318:
URL: https://github.com/apache/ozone/pull/9318#discussion_r2541595487


##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/HddsServerUtil.java:
##########
@@ -422,7 +422,7 @@ public static Collection<String> 
getOzoneDatanodeRatisDirectory(
 
     if (rawLocations.isEmpty()) {
       rawLocations = new ArrayList<>(1);
-      rawLocations.add(ServerUtils.getDefaultRatisDirectory(conf));
+      rawLocations.add(ServerUtils.getDefaultRatisDirectory(conf, "dn"));

Review Comment:
   > In production, scm, om and dns will be on different host and will be on HA
   
   Yes I agree with this, but if any user wants to deploy with minimum setups 
using ozone-upstream code then there is only one **`ozone-site.xml`** for all 
scm, om and dns so this issue can happen ss if they don't set different path 
for each of them then all will fallback to `ozone.metadata.dirs` ultimately 
throwing `OverlappingFileLockException` . Like this 
[PR](https://github.com/apache/ozone/pull/9247) raised by @ssulav .
   
   > still if resolving issue of same host, can check if dnid can be used here? 
or something else
   
   For this I will try to see if anything possible and update you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to