smengcl commented on code in PR #9313:
URL: https://github.com/apache/ozone/pull/9313#discussion_r2545976421
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java:
##########
@@ -181,11 +181,14 @@ public String getSnapshotLocalPropertyYamlPath(UUID
snapshotId) {
public void createNewOmSnapshotLocalDataFile(RDBStore snapshotStore,
SnapshotInfo snapshotInfo) throws IOException {
try (WritableOmSnapshotLocalDataProvider snapshotLocalData =
new
WritableOmSnapshotLocalDataProvider(snapshotInfo.getSnapshotId(),
- () -> Pair.of(new
OmSnapshotLocalData(snapshotInfo.getSnapshotId(),
-
getLiveSSTFilesForCFs(snapshotStore.getDb().getManagedRocksDb(),
- COLUMN_FAMILIES_TO_TRACK_IN_SNAPSHOT),
- snapshotInfo.getPathPreviousSnapshotId(), null),
- null))) {
+ () -> {
+ List<LiveFileMetaData> lfms =
getLiveSSTFilesForCFs(snapshotStore.getDb().getManagedRocksDb(),
+ COLUMN_FAMILIES_TO_TRACK_IN_SNAPSHOT);
+ long dbTxnSeqNumber =
lfms.stream().mapToLong(LiveFileMetaData::largestSeqno).max().orElse(0L);
Review Comment:
Do we still want to fall back to the dbTxSeqNumber stored in SnapshotInfo
proto?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
