peterxcli commented on code in PR #9222:
URL: https://github.com/apache/ozone/pull/9222#discussion_r2548829965
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServerConfig.java:
##########
@@ -52,6 +52,27 @@ public class OzoneManagerRatisServerConfig {
)
private long retryCacheTimeout = Duration.ofSeconds(300).toMillis();
+ @Config(key = "read.option",
+ defaultValue = "DEFAULT",
+ type = ConfigType.STRING,
+ tags = {OZONE, OM, RATIS, PERFORMANCE},
+ description = "Select the Ratis server read option." +
+ " Possible values are: " +
+ " DEFAULT - Directly query statemachine (non-linearizable). "
+
+ " Only the leader can serve read requests. " +
Review Comment:
```suggestion
" DEFAULT - Directly query statemachine. " +
" Only the leader can serve read requests. " +
```
IIUC, the current DEFAULT is still linearizable. To avoid confusion, let’s
rename the modes to something more explicit—for example:
- leader-only
- follower-linearizable
- follower-stale-read (as introduced in
https://github.com/apache/ozone/pull/9320)
Then we can add our own parsing that maps these OM-level configs to the
corresponding Ratis read options, instead of relying directly on
RaftServerConfigKeys.Read.option(...).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
