rich7420 commented on code in PR #9173:
URL: https://github.com/apache/ozone/pull/9173#discussion_r2553753036
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/QuotaRepairTask.java:
##########
@@ -102,14 +102,13 @@ public static String getStatus() {
private boolean repairTask(List<String> buckets) {
LOG.info("Starting quota repair task {}", REPAIR_STATUS);
- OMMetadataManager activeMetaManager = null;
- try {
- // thread pool with 3 Table type * (1 task each + 3 thread for each task)
- executor = Executors.newFixedThreadPool(3 * (1 + TASK_THREAD_CNT));
+ // thread pool with 3 Table type * (1 task each + 3 thread for each task)
+ executor = Executors.newFixedThreadPool(3 * (1 + TASK_THREAD_CNT));
+ try (OMMetadataManager activeMetaManager =
Review Comment:
sorry @peterxcli , this change will get error. I think maybe is because
executor is not AutoCloseable so we couldn't put it in try-with-resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
