ChenSammi commented on code in PR #9310:
URL: https://github.com/apache/ozone/pull/9310#discussion_r2554914632
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStartSubcommand.java:
##########
@@ -109,4 +136,27 @@ protected void displayResults(List<String> successNodes,
}
}
}
+
+ @Override
+ protected String getActionName() {
+ return "start";
+ }
+
+ @Override
+ protected Map<String, Object> getConfigurationMap() {
Review Comment:
For DiskBalancerUpdateSubcommand and DiskBalancerStartSubcommand,
getConfigurationMap() code is same as part of executeCommand, can
getConfigurationMap reuse the result of executeCommand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]