devabhishekpal commented on code in PR #9359:
URL: https://github.com/apache/ozone/pull/9359#discussion_r2559569425
##########
hadoop-ozone/dev-support/checks/_lib.sh:
##########
@@ -40,13 +40,17 @@ _install_tool() {
return
fi
- if [[ ! -d "${dir}" ]]; then
+ if [[ ! -d "${dir}" ]] || ! which "$bin" >& /dev/null; then
mkdir -pv "${dir}"
pushd "${dir}"
if eval "${func}"; then
Review Comment:
Do you think it might be good to redirect the standard error to the output
file as well?
```
if eval "${func}" 2>> "${REPORT_FILE}"; then
```
This would help us know what actually went wrong while trying to install the
tool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
