adoroszlai commented on code in PR #9360:
URL: https://github.com/apache/ozone/pull/9360#discussion_r2559921126
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1965,17 +1965,17 @@ private class TableInitializer {
this.addCacheMetrics = addCacheMetrics;
}
- <KEY, VALUE> TypedTable<KEY, VALUE> get(DBColumnFamilyDefinition<KEY,
VALUE> definition)
+ <KEY, VALUE> Table<KEY, VALUE> get(DBColumnFamilyDefinition<KEY, VALUE>
definition)
throws IOException {
return get(definition.getTable(store));
}
- <KEY, VALUE> TypedTable<KEY, VALUE> get(DBColumnFamilyDefinition<KEY,
VALUE> definition, CacheType cacheType)
+ <KEY, VALUE> Table<KEY, VALUE> get(DBColumnFamilyDefinition<KEY, VALUE>
definition, CacheType cacheType)
throws IOException {
return get(definition.getTable(store, cacheType));
}
- private <KEY, VALUE> TypedTable<KEY, VALUE> get(TypedTable<KEY, VALUE>
table) {
+ private <KEY, VALUE> Table<KEY, VALUE> get(Table<KEY, VALUE> table) throws
RocksDatabaseException {
Review Comment:
Instead of adding `throws RocksDatabaseException`, I think it should be
removed from:
https://github.com/apache/ozone/blob/7c53356a5e41499ebc3e7bf67540a24603d0f502/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/Table.java#L271
since no implementation throws it, and `TableCacheMetrics` is not specific
to RocksDB.
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/InMemoryTestTable.java:
##########
@@ -97,7 +97,7 @@ public void deleteRangeWithBatch(BatchOperation batch, KEY
beginKey, KEY endKey)
@Override
public void deleteRange(KEY beginKey, KEY endKey) {
- throw new UnsupportedOperationException();
+ map.subMap(beginKey, endKey).clear();
Review Comment:
Isn't this part of a follow-up change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
