jojochuang commented on code in PR #9353:
URL: https://github.com/apache/ozone/pull/9353#discussion_r2561052263
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/PoolBasedHierarchicalResourceLockManager.java:
##########
@@ -144,6 +160,40 @@ public void close() {
this.lockPool.close();
}
+ /**
+ * The PoolBasedHierachicalResourceLock class implements the
HierarchicalResourceLock
+ * and UncheckedAutoCloseable interfaces to manage hierarchical resource
locks from
+ * a shared pool. It ensures proper lock acquisition and release during its
lifecycle.
+ */
+ private final class PoolBasedHierachicalResourceLock implements
HierarchicalResourceLock,
Review Comment:
is this a duplicate by any chance? Seems quite similar to
PoolBasedHierarchicalResourceKeyLock below
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/lock/TestPoolBasedHierarchicalResourceLockManager.java:
##########
@@ -585,7 +648,8 @@ public void testDAGLockOrderAcquisition(DAGLeveledResource
dagLeveledResource) t
String otherResourceName1 = otherResource.getName() + "key";
String otherResourceName2 = otherResource.getName() + "key";
String flatResourceName = dagLeveledResource.getName() + "key";
Review Comment:
String dagResourceName = dagLeveledResource.getName() + "key";
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
