peterxcli commented on code in PR #9362:
URL: https://github.com/apache/ozone/pull/9362#discussion_r2561358954
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java:
##########
@@ -359,6 +359,10 @@ public final class ScmConfigKeys {
"ozone.scm.container.size";
public static final String OZONE_SCM_CONTAINER_SIZE_DEFAULT = "5GB";
+ public static final String OZONE_SCM_CONTAINER_SPACE_REQUIREMENT_MULTIPLIER =
Review Comment:
I’m thinking this patch only needs to add a config to set the required data
size (dataSizeRequired), which we can then read from ReplicationManagerUtil
here:
https://github.com/peterxcli/ozone/blob/7868a862ff616154e4bd9ab52dada929e15042ec/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManagerUtil.java#L93-L94.
@siddhantsangwan does this approach look correct?
##########
.github/workflows/intermittent-test-check.yml:
##########
@@ -223,7 +223,7 @@ jobs:
env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
- name: Summary of failures
- run: hadoop-ozone/dev-support/checks/_summary.sh
target/unit/summary.txt
+ run: hadoop-ozone/dev-support/checks/_summary.sh
target/unit/summary.txt || true
Review Comment:
```suggestion
run: hadoop-ozone/dev-support/checks/_summary.sh
target/unit/summary.txt
```
##########
.github/workflows/repeat-acceptance.yml:
##########
@@ -150,7 +150,7 @@ jobs:
KEEP_IMAGE: false
continue-on-error: true
- name: Summary of failures
- run: hadoop-ozone/dev-support/checks/_summary.sh target/${{ github.job
}}/summary.txt
+ run: hadoop-ozone/dev-support/checks/_summary.sh target/${{ github.job
}}/summary.txt || true
Review Comment:
```suggestion
run: hadoop-ozone/dev-support/checks/_summary.sh target/${{
github.job }}/summary.txt
```
##########
.github/workflows/check.yml:
##########
@@ -247,7 +247,7 @@ jobs:
if [[ -s "target/${{ inputs.script }}/summary.md" ]]; then
cat target/${{ inputs.script }}/summary.md >> $GITHUB_STEP_SUMMARY
fi
- hadoop-ozone/dev-support/checks/_summary.sh target/${{ inputs.script
}}/summary.txt
+ hadoop-ozone/dev-support/checks/_summary.sh target/${{ inputs.script
}}/summary.txt || true
Review Comment:
```suggestion
hadoop-ozone/dev-support/checks/_summary.sh target/${{
inputs.script }}/summary.txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
