Gargi-jais11 commented on PR #9370: URL: https://github.com/apache/ozone/pull/9370#issuecomment-3579646738
@Russole if I am not wrong, I couldn't find any test classes dedicated to testing `OzoneOutputStream` although indirect testing is done through `TestKeyOutputStream.java`. So I think we can have a new unit test class dedicated for `OzoneOutputStream` testing under the below path: `/ozone/hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/io/TestOzoneOutputStream.java`. Here, you can test the following scenarios: 1. test Plain `KeyOutputStream and getMetadata()` (no encryption) 2. test `GetKeyOutputStream and getMetadata() `wrapped inside CryptoWrapper() 3. test `GetKeyOutputStream and getMetadata()` wrapped inside CipherOutputStreamOzone 4. test for Non-KeyMetadataAware stream verify that exception is thrown here. @peterxcli what do you think about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
