[
https://issues.apache.org/jira/browse/HDDS-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Andika updated HDDS-14016:
-------------------------------
Description:
Currently, reconfiguration implementation calls `OzoneConfiguration#set` in the
`ReconfigurableBase#reconfigurePropertyImpl` implementation. However, we should
defer setting the configuration field in
`ReconfigurationBase#reconfigureProperty`. This will handle issues where there
are exceptions during the reconfigurePropertyImpl. Currently, this is fine
since most of the reconfigurations are simple and do not throw exceptions
(although the configuration field is set twice). However, for more complex
cases like HDDS-13913, the effective configuration value that is set might be
different than the configuration value to set (e.g. excluding SCM nodes that
cannot be connected).
The tests should also use `reconfigureProperty` instead of
`reconfigurePropertyImpl`.
was:
Currently, reconfiguration implementation calls `OzoneConfiguration#set` in the
`ReconfigurableBase#reconfigurePropertyImpl` implementation. However, we should
defer setting the configuration field in
`ReconfigurationBase#reconfigureProperty`. This will handle issues where there
are exceptions during the reconfigurePropertyImpl. Currently, this is fine
since most of the reconfigurations are simple and do not throw exceptions
(although the configuration field is set twice). However, for more complex
cases like HDDS-13913, the effective configuration value that is set might be
different than the configuration value to set.
The tests should also use `reconfigureProperty` instead of
`reconfigurePropertyImpl`.
> reconfigurePropertyImpl should not manually set configuration
> -------------------------------------------------------------
>
> Key: HDDS-14016
> URL: https://issues.apache.org/jira/browse/HDDS-14016
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Minor
>
> Currently, reconfiguration implementation calls `OzoneConfiguration#set` in
> the `ReconfigurableBase#reconfigurePropertyImpl` implementation. However, we
> should defer setting the configuration field in
> `ReconfigurationBase#reconfigureProperty`. This will handle issues where
> there are exceptions during the reconfigurePropertyImpl. Currently, this is
> fine since most of the reconfigurations are simple and do not throw
> exceptions (although the configuration field is set twice). However, for more
> complex cases like HDDS-13913, the effective configuration value that is set
> might be different than the configuration value to set (e.g. excluding SCM
> nodes that cannot be connected).
> The tests should also use `reconfigureProperty` instead of
> `reconfigurePropertyImpl`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
