swamirishi commented on code in PR #9335:
URL: https://github.com/apache/ozone/pull/9335#discussion_r2564537380
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMDBCheckpointServletInodeBasedXfer.java:
##########
@@ -399,12 +436,12 @@ private OzoneConfiguration getConf() {
* Collects paths to all snapshot databases from the OM DB.
*
* @param activeOMMetadataManager OMMetadataManager instance
- * @return Set of paths to snapshot databases
+ * @return Map of paths to snapshot databases with snapshot IDs as keys.
* @throws IOException if an I/O error occurs
*/
- Set<Path> getSnapshotDirsFromDB(OMMetadataManager activeOMMetadataManager,
OMMetadataManager omMetadataManager,
+ Map<UUID, Path> getSnapshotDirsFromDB(OMMetadataManager
activeOMMetadataManager, OMMetadataManager omMetadataManager,
OmSnapshotLocalDataManager localDataManager) throws IOException {
- Set<Path> snapshotPaths = new HashSet<>();
+ Map<UUID, Path> snapshotPaths = new HashMap<>();
try (TableIterator<String, ? extends Table.KeyValue<String, SnapshotInfo>>
iter =
omMetadataManager.getSnapshotInfoTable().iterator()) {
while (iter.hasNext()) {
Review Comment:
No during bootstrap even the deleted snapshots are copied. SNAPSHOT_DELETED
is an intermediate state. When a snapshot is purged that is when the entry is
completely removed from the system. Then the snapshotInfo table won't have the
entries in checkpoint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
