ashishkumar50 commented on code in PR #9350:
URL: https://github.com/apache/ozone/pull/9350#discussion_r2568575354
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -1532,10 +1532,8 @@ public void start() throws IOException {
}
getBlockProtocolServer().start();
- // If HA is enabled, start datanode protocol server once leader is ready.
- if (!scmStorageConfig.isSCMHAEnabled()) {
- getDatanodeProtocolServer().start();
- }
+ // start datanode protocol server
+ getDatanodeProtocolServer().start();
Review Comment:
When leader is not elected/ready heartbeat can can be received/sent. I think
we should set empty response in `sendHeartbeat.`
What is the main purpose here to start datanode protocol server immediately
without having leader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
