[
https://issues.apache.org/jira/browse/HDDS-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-14016.
-------------------------------------
Fix Version/s: 2.2.0
Resolution: Fixed
> Reconfigure function should not manually set configuration
> ----------------------------------------------------------
>
> Key: HDDS-14016
> URL: https://issues.apache.org/jira/browse/HDDS-14016
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.2.0
>
>
> Currently, reconfiguration implementation calls `OzoneConfiguration#set` in
> the `ReconfigurableBase#reconfigurePropertyImpl` implementation. However, we
> should defer setting the configuration field in
> `ReconfigurationBase#reconfigureProperty`. This will handle issues where
> there are exceptions during the reconfigurePropertyImpl. Currently, this is
> fine since most of the reconfigurations are simple and do not throw
> exceptions (although the configuration field is set twice). However, for more
> complex cases like HDDS-13913, the effective configuration value that is set
> might be different than the configuration value to set (e.g. excluding SCM
> nodes that cannot be connected).
> The tests should also use `reconfigureProperty` instead of
> `reconfigurePropertyImpl`.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
