[ 
https://issues.apache.org/jira/browse/HDDS-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344774#comment-17344774
 ] 

Hanisha Koneru commented on HDDS-5228:
--------------------------------------

One thing to note though is that we cannot failover to a suggested leader using 
the default \{{FailoverProxyProvider#performFailover(T currentProxy)}}, unless 
we use the currentProxy parameter to specify the proxy to failover to (would 
have to dig deeper to see implications if any). Even though 
OMFailoverProxyProvider is currently not failing over to the suggested leader, 
we might want to explore this option in the future.
{quote}With this, if RpcClient shared across threads it will unnecessarily 
exhaust the retry count.
{quote}
Even if RpcClient is shared across threads, they all will have the same 
FailoverProxyProvider. If the 1st thread fails over and discovers the leader 
OM, all the subsequent requests from any thread) will be directed to the 
correct OM. I do not see how the retry count will be exhausted because of 
shared threads. Please let me know if I am missing something here.

 

> Make OM FailOverProxyProvider work across threads
> -------------------------------------------------
>
>                 Key: HDDS-5228
>                 URL: https://issues.apache.org/jira/browse/HDDS-5228
>             Project: Apache Ozone
>          Issue Type: Improvement
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>
> Use perform failover for doing perform failover instead of updating proxy in 
> RetryPolocy#shouldRetry.
> With this, if RpcClient shared across threads it will unnecessarily exhaust 
> the retry count. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to