[
https://issues.apache.org/jira/browse/HDDS-14058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-14058:
------------------------------------
Description:
Replace {{Preconditions.checkNotNull}} in all test code.
- Add message where missing, e.g.: {{Objects.requireNonNull(var, "var ==
null");}}
- Make sure to remove import of {{Preconditions}} if it becomes unused.
Currently the list is the following:
{code}
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ScmTestMock.java
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/HddsTestUtils.java
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestSequenceIDGenerator.java
hadoop-hdds/test-utils/src/test/java/org/apache/ozone/test/GenericTestUtils.java
hadoop-hdds/test-utils/src/test/java/org/apache/ozone/test/LambdaTestUtils.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/parser/TestOzoneHARatisLogParser.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneContainerUpgradeShell.java
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/file/TestOMRecoverLeaseRequest.java
{code}
was:
Replace {{Preconditions.checkNotNull}} in all test code. Currently the list is
the following:
{code}
hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ScmTestMock.java
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/HddsTestUtils.java
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestSequenceIDGenerator.java
hadoop-hdds/test-utils/src/test/java/org/apache/ozone/test/GenericTestUtils.java
hadoop-hdds/test-utils/src/test/java/org/apache/ozone/test/LambdaTestUtils.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/parser/TestOzoneHARatisLogParser.java
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneContainerUpgradeShell.java
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/file/TestOMRecoverLeaseRequest.java
{code}
> Replace Preconditions.checkNotNull in tests
> -------------------------------------------
>
> Key: HDDS-14058
> URL: https://issues.apache.org/jira/browse/HDDS-14058
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Attila Doroszlai
> Priority: Major
>
> Replace {{Preconditions.checkNotNull}} in all test code.
> - Add message where missing, e.g.: {{Objects.requireNonNull(var, "var ==
> null");}}
> - Make sure to remove import of {{Preconditions}} if it becomes unused.
> Currently the list is the following:
> {code}
> hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/container/ContainerTestHelper.java
> hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ScmTestMock.java
> hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/HddsTestUtils.java
> hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
> hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestSequenceIDGenerator.java
> hadoop-hdds/test-utils/src/test/java/org/apache/ozone/test/GenericTestUtils.java
> hadoop-hdds/test-utils/src/test/java/org/apache/ozone/test/LambdaTestUtils.java
> hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/parser/TestOzoneHARatisLogParser.java
> hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneContainerUpgradeShell.java
> hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/file/TestOMRecoverLeaseRequest.java
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
