ChenSammi commented on code in PR #9403:
URL: https://github.com/apache/ozone/pull/9403#discussion_r2583562142
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java:
##########
@@ -799,11 +804,42 @@ public void incNumKeyDeleteFails() {
numKeyDeleteFails.incr();
}
+ public void incNumKeyDeleteFails(int count) {
+ numKeyDeleteFails.incr(count);
+ }
+
+ public void incNumKeyRetentionDeleteFails(int count) {
+ numKeyRetentionDeleteFails.incr(count);
+ }
+
+ public void incNumKeyTrashDeleteFails(int count) {
+ numKeyTrashDeleteFails.incr(count);
+ }
+
public void incNumKeyDeletes() {
numKeyOps.incr();
numKeyDeletes.incr();
}
+ public void incNumKeyDeletesWithoutOps() {
+ numKeyDeletes.incr();
Review Comment:
I see. If we look at this function
```
public void incNumCreateDirectory() {
numKeyOps.incr();
numFSOps.incr();
numCreateDirectory.incr();
}
```
I think incNumKeyDeletesWithoutOps can be improved like
```
public void incNumDirectoryDeletes() {
numKeyOps.incr();
numFSOps.incr();
numKeyDeletes.incr();
}
```
What do you think? Because this WithoutOps appendix is kind of a confusing
naming to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
