fmorg-git commented on PR #9315: URL: https://github.com/apache/ozone/pull/9315#issuecomment-3614859706
hi @ChenSammi - I just rebased this PR and it is ready for review - thanks! Please note that some of the updates from Part 3 needed to be changed back because test cases added in this PR revealed that some assumptions weren't correct. For example, we need `EnumSet.of(ACLType.ALL)` for volume perms in `ALL_S3` in case `s3:*` is provided - this should apply `ALL` at the volume level as well, not just `READ`. For that reason, I had to put the individual `EnumSet.of(READ)` back in `processBucketResource`, `processObjectExactResource` and `processObjectPrefixResource`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
