echonesis commented on code in PR #9427:
URL: https://github.com/apache/ozone/pull/9427#discussion_r2591214380
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/helpers/OmPrefixInfo.java:
##########
@@ -61,19 +63,7 @@ public static Codec<OmPrefixInfo> getCodec() {
* @return {@literal List<OzoneAcl>}
*/
public List<OzoneAcl> getAcls() {
- return acls;
- }
-
- public boolean addAcl(OzoneAcl acl) {
- return OzoneAclUtil.addAcl(acls, acl);
- }
-
- public boolean removeAcl(OzoneAcl acl) {
- return OzoneAclUtil.removeAcl(acls, acl);
- }
-
- public boolean setAcls(List<OzoneAcl> newAcls) {
- return OzoneAclUtil.setAcl(acls, newAcls);
+ return ImmutableList.copyOf(acls);
Review Comment:
Yes, you are correct; it is already an `ImmutableList`.
However, **SpotBugs (FindBugs)** appears to be **mistakenly reporting** an
issue when detected via:
```
grep -c 'OmPrefixInfo' target/findbugs/summary.txt
```
Given this, should we proceed to return `acls` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
