swamirishi commented on code in PR #9132:
URL: https://github.com/apache/ozone/pull/9132#discussion_r2594840860
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RDBSnapshotProvider.java:
##########
@@ -121,13 +122,13 @@ public DBCheckpoint downloadDBSnapshotFromLeader(String
leaderNodeID)
numDownloaded.incrementAndGet();
injectPause();
- RocksDBCheckpoint checkpoint = getCheckpointFromSnapshotFile(targetFile,
+ Path unTarredDb = untarContentsOfTarball(targetFile,
candidateDir, true);
LOG.info("Successfully untar the downloaded snapshot {} at {}.",
- targetFile, checkpoint.getCheckpointLocation());
- if (ratisSnapshotComplete(checkpoint.getCheckpointLocation())) {
+ targetFile, unTarredDb.toAbsolutePath());
+ if (ratisSnapshotComplete(unTarredDb)) {
LOG.info("Ratis snapshot transfer is complete.");
- return checkpoint;
+ return new InodeMetadataRocksDBCheckpoint(unTarredDb);
Review Comment:
Eventually we should use the same model for SCM as well.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/RDBSnapshotProvider.java:
##########
@@ -121,13 +122,13 @@ public DBCheckpoint downloadDBSnapshotFromLeader(String
leaderNodeID)
numDownloaded.incrementAndGet();
injectPause();
- RocksDBCheckpoint checkpoint = getCheckpointFromSnapshotFile(targetFile,
+ Path unTarredDb = untarContentsOfTarball(targetFile,
candidateDir, true);
LOG.info("Successfully untar the downloaded snapshot {} at {}.",
- targetFile, checkpoint.getCheckpointLocation());
- if (ratisSnapshotComplete(checkpoint.getCheckpointLocation())) {
+ targetFile, unTarredDb.toAbsolutePath());
+ if (ratisSnapshotComplete(unTarredDb)) {
LOG.info("Ratis snapshot transfer is complete.");
- return checkpoint;
+ return new InodeMetadataRocksDBCheckpoint(unTarredDb);
Review Comment:
Eventually we should use the same interface for SCM as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
