adoroszlai commented on code in PR #9450:
URL: https://github.com/apache/ozone/pull/9450#discussion_r2595087823
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateMap.java:
##########
@@ -223,9 +224,9 @@ List<Pipeline> getPipelines(ReplicationConfig
replicationConfig,
*/
int getPipelineCount(ReplicationConfig replicationConfig,
PipelineState state) {
- Preconditions
- .checkNotNull(replicationConfig, "ReplicationConfig cannot be null");
- Preconditions.checkNotNull(state, "Pipeline state cannot be null");
+ Objects
+ .requireNonNull(replicationConfig, "ReplicationConfig cannot be null");
Review Comment:
```suggestion
Objects.requireNonNull(replicationConfig, "ReplicationConfig cannot be
null");
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateMap.java:
##########
@@ -256,9 +257,9 @@ int getPipelineCount(ReplicationConfig replicationConfig,
List<Pipeline> getPipelines(ReplicationConfig replicationConfig,
PipelineState state, Collection<DatanodeDetails> excludeDns,
Collection<PipelineID> excludePipelines) {
- Preconditions
- .checkNotNull(replicationConfig, "ReplicationConfig cannot be null");
- Preconditions.checkNotNull(state, "Pipeline state cannot be null");
+ Objects
+ .requireNonNull(replicationConfig, "ReplicationConfig cannot be null");
Review Comment:
```suggestion
Objects.requireNonNull(replicationConfig, "ReplicationConfig cannot be
null");
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/metrics/SCMNodeMetric.java:
##########
@@ -58,8 +58,8 @@ public SCMNodeMetric(long capacity, long used, long remaining,
*/
@Override
public boolean isGreater(SCMNodeStat o) {
- Preconditions.checkNotNull(this.stat, "Argument cannot be null");
- Preconditions.checkNotNull(o, "Argument cannot be null");
+ Objects.requireNonNull(this.stat, "Argument cannot be null");
Review Comment:
Please move this check to:
```java
public SCMNodeMetric(SCMNodeStat stat) {
this.stat = Objects.requireNonNull(stat, "stat == null");
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineStateMap.java:
##########
@@ -191,9 +192,9 @@ List<Pipeline> getPipelines(ReplicationConfig
replicationConfig) {
*/
List<Pipeline> getPipelines(ReplicationConfig replicationConfig,
PipelineState state) {
- Preconditions
- .checkNotNull(replicationConfig, "ReplicationConfig cannot be null");
- Preconditions.checkNotNull(state, "Pipeline state cannot be null");
+ Objects
+ .requireNonNull(replicationConfig, "ReplicationConfig cannot be null");
Review Comment:
```suggestion
Objects.requireNonNull(replicationConfig, "ReplicationConfig cannot be
null");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
