ArafatKhan2198 commented on code in PR #9436:
URL: https://github.com/apache/ozone/pull/9436#discussion_r2596549430
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -272,6 +272,7 @@ public void start() {
throw new RuntimeException(runtimeException);
}
}
+ reconTaskController.updateOMMetadataManager(omMetadataManager);
Review Comment:
Without this line, we saw this error in the upgrade logs:
```
7:41:57.794 PM ERROR ReconLayoutVersionManager: Failed to finalize feature
3. Rolling back changes.
java.lang.NullPointerException: Cannot invoke
"org.apache.hadoop.ozone.recon.recovery.ReconOMMetadataManager.getStore()"
because "omMetaManager" is null
at
ReconTaskControllerImpl.cleanTempCheckPointPath(ReconTaskControllerImpl.java:624)
at
ReconTaskControllerImpl.createOMCheckpoint(ReconTaskControllerImpl.java:607)
at
ReconTaskControllerImpl.queueReInitializationEvent(ReconTaskControllerImpl.java:503)
at
NSSummaryAggregatedTotalsUpgrade.execute(NSSummaryAggregatedTotalsUpgrade.java:54)
```
The `NSSummaryAggregatedTotalsUpgrade` handler tries to create a checkpoint
using `currentOMMetadataManager`, but it's null because
`updateOMMetadataManager()` was never called during startup - it was only
called later in the periodic `syncDataFromOM()` task. Adding this line sets
`currentOMMetadataManager` before upgrades run, allowing feature 3 to finalize
successfully as shown in the fixed logs: `"Feature versioned 3 finalized
successfully"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
