priyeshkaratha commented on code in PR #9413: URL: https://github.com/apache/ozone/pull/9413#discussion_r2597397510
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/DataNodeMetricsService.java: ########## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.api; + +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_HTTP_CONNECTION_TIMEOUT; +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_HTTP_CONNECTION_TIMEOUT_DEFAULT; +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_HTTP_REQUEST_TIMEOUT; +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_HTTP_REQUEST_TIMEOUT_DEFAULT; +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_HTTP_SOCKET_TIMEOUT; +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_HTTP_SOCKET_TIMEOUT_DEFAULT; +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_METRICS_COLLECTION_THREAD_COUNT; +import static org.apache.hadoop.ozone.recon.ReconServerConfigKeys.OZONE_RECON_DN_METRICS_COLLECTION_THREAD_COUNT_DEFAULT; + +import java.util.ArrayList; +import java.util.List; +import java.util.Set; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.TimeoutException; +import javax.inject.Inject; +import javax.inject.Singleton; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.scm.server.OzoneStorageContainerManager; +import org.apache.hadoop.hdds.server.http.HttpConfig; +import org.apache.hadoop.ozone.recon.api.types.DataNodeMetricsServiceResponse; +import org.apache.hadoop.ozone.recon.api.types.DatanodePendingDeletionMetrics; +import org.apache.hadoop.ozone.recon.scm.ReconNodeManager; +import org.apache.hadoop.ozone.recon.tasks.DataNodeMetricsCollectionTask; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +/** + * The DataNodeMetricsService class is responsible for collecting and managing + * metrics related to datanodes in an Ozone Recon environment. Specifically, + * it gathers metrics about pending block deletions from the datanodes and + * provides aggregated results. + * This service tracks the status of metric collection tasks and provides + * an interface to query the state and results of these tasks. + * The metrics collection process involves communicating with each datanode, + * fetching their pending deletion metrics, and aggregating the data. + */ + +@Singleton +public class DataNodeMetricsService { + private static final Logger LOG = LoggerFactory.getLogger(DataNodeMetricsService.class); + private MetricCollectionStatus currentStatus = MetricCollectionStatus.NOT_STARTED; + private Long totalPendingDeletion = 0L; + private List<DatanodePendingDeletionMetrics> pendingDeletionList; + private final ReconNodeManager reconNodeManager; + private final int threadCount; + private final int httpRequestTimeout; + private final int httpConnectionTimeout; + private final int httpSocketTimeout; + private final boolean httpsEnabled; + + @Inject + public DataNodeMetricsService(OzoneStorageContainerManager reconSCM, OzoneConfiguration conf) { + reconNodeManager = (ReconNodeManager) reconSCM.getScmNodeManager(); + threadCount = conf.getInt(OZONE_RECON_DN_METRICS_COLLECTION_THREAD_COUNT, + OZONE_RECON_DN_METRICS_COLLECTION_THREAD_COUNT_DEFAULT); + httpRequestTimeout = conf.getInt(OZONE_RECON_DN_HTTP_REQUEST_TIMEOUT, OZONE_RECON_DN_HTTP_REQUEST_TIMEOUT_DEFAULT); + httpConnectionTimeout = conf.getInt(OZONE_RECON_DN_HTTP_CONNECTION_TIMEOUT, + OZONE_RECON_DN_HTTP_CONNECTION_TIMEOUT_DEFAULT); + httpSocketTimeout = conf.getInt(OZONE_RECON_DN_HTTP_SOCKET_TIMEOUT, OZONE_RECON_DN_HTTP_SOCKET_TIMEOUT_DEFAULT); + httpsEnabled = HttpConfig.getHttpPolicy(conf).isHttpsEnabled(); + } + + public void startTask() { + Set<DatanodeDetails> nodes = reconNodeManager.getNodeStats().keySet(); + pendingDeletionList = new ArrayList<>(nodes.size()); + totalPendingDeletion = 0L; + currentStatus = MetricCollectionStatus.IN_PROGRESS; + ExecutorService executor = Executors.newFixedThreadPool(threadCount); + List<Future<DatanodePendingDeletionMetrics>> futures = new ArrayList<>(); + for (DatanodeDetails node : nodes) { + DataNodeMetricsCollectionTask task = DataNodeMetricsCollectionTask.newBuilder() + .setNodeDetails(node) + .setHttpConnectionTimeout(httpConnectionTimeout) + .setHttpSocketTimeout(httpSocketTimeout) + .setHttpsEnabled(httpsEnabled) + .build(); + futures.add(executor.submit(task)); + } + boolean hasTimedOut = false; + for (Future<DatanodePendingDeletionMetrics> future : futures) { + try { + DatanodePendingDeletionMetrics result = future.get(httpRequestTimeout, TimeUnit.SECONDS); + totalPendingDeletion += result.getPendingBlockSize(); + pendingDeletionList.add(result); + } catch (TimeoutException e) { + hasTimedOut = true; + LOG.error("Task timed out after " + httpRequestTimeout + " seconds: {}", e.getMessage()); + } catch (Exception e) { + System.err.println("Task failed or was interrupted: " + e.getMessage()); + } + } + executor.shutdown(); + if (hasTimedOut) { + currentStatus = MetricCollectionStatus.FAILED; Review Comment: I have removed FAILED status since its not required even though we return values on failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
