ChenSammi commented on code in PR #9282:
URL: https://github.com/apache/ozone/pull/9282#discussion_r2597534246
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManagerStarter.java:
##########
@@ -128,9 +128,17 @@ public void initScm(@CommandLine.Option(names = {
"--clusterid" },
public void bootStrapScm()
throws Exception {
commonInit();
- boolean result = receiver.bootStrap(conf);
- if (!result) {
- throw new IOException("scm bootstrap failed");
+ try {
+ boolean result = receiver.bootStrap(conf);
+ if (!result) {
+ throw new IOException("scm bootstrap failed");
+ }
+ } catch (IOException e) {
Review Comment:
Please move if (!result) out of try scope, we don't want to handle the self
thrown exception again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
