fmorg-git commented on code in PR #9445: URL: https://github.com/apache/ozone/pull/9445#discussion_r2603794088
########## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/security/TestSTSTokenIdentifier.java: ########## Review Comment: it is mainly for slight performance improvement. `SecureRandom` can sometimes block, and also since this is a unit test with dummy data, there is no need for strong cryptographic generation of encryption key, so I switched to `ThreadLocalRandom`. I used `ThreadLocalRandom` in this PR for `TestS3SecurityUtil` unit test and I remembered this other change from a previous PR, so I just changed it as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
