Russole commented on code in PR #9371:
URL: https://github.com/apache/ozone/pull/9371#discussion_r2603826632
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketPut.java:
##########
@@ -40,6 +58,26 @@ public class TestBucketPut {
private String bucketName = OzoneConsts.BUCKET;
private BucketEndpoint bucketEndpoint;
+ private HttpHeaders mockHeaders;
+ private static final String VALID_ACL_XML =
+ "<AccessControlPolicy xmlns=\"http://s3.amazonaws.com/doc/2006-03-01/\";
" +
+ "
xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\";>" +
+ " <Owner>" +
+ " <ID>owner-id</ID>" +
+ " <DisplayName>owner-name</DisplayName>" +
+ " </Owner>" +
+ " <AccessControlList>" +
+ " <Grant>" +
+ " <Grantee xsi:type=\"CanonicalUser\">" +
+ " <ID>owner-id</ID>" +
+ " <DisplayName>owner-name</DisplayName>" +
+ " </Grantee>" +
+ " <Permission>FULL_CONTROL</Permission>" +
+ " </Grant>" +
+ " </AccessControlList>" +
+ "</AccessControlPolicy>";
+ private static final String ACL = "acl";
Review Comment:
Thanks for the suggestion!
I've removed the local "acl" constant and updated the tests to use
OzoneConsts.ACL so that we rely on the shared Ozone constant instead of
redefining it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
