ChenSammi commented on code in PR #9426:
URL: https://github.com/apache/ozone/pull/9426#discussion_r2605462760


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyLifecycleService.java:
##########
@@ -331,6 +347,11 @@ public BackgroundTaskResult call() {
           return result;
         }
 
+        if (!shouldRun()) {

Review Comment:
   When it comes here, the key evaluation is finished, the rest of work is 
sending the expired remaining key to delete/rename. I think we can let this run 
to finish, instead of return here.  
   
   The most time consuming part of DB key evaluation iteration, send keys to 
delete/rename doesn't take much time. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to