len548 commented on code in PR #9343:
URL: https://github.com/apache/ozone/pull/9343#discussion_r2607663094


##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/signature/TestStringToSignProducer.java:
##########
@@ -94,6 +94,7 @@ public void validateDateRange(Credential credentialObj) {
             //NOOP
           }
         }.parseSignature();
+    signatureInfo.setPayloadHash("Content-SHA");

Review Comment:
   If you look at the input string `canonicalRequest` from [line 
67](https://github.com/apache/ozone/blob/2062a06942e14e1093b0b78b5de022e266b88d35/hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/signature/TestStringToSignProducer.java#L67-L74)
 in this test, the structure of the string is 
   ```
   <HTTPMethod>\n
   <CanonicalURI>\n
   <CanonicalQueryString>\n
   <CanonicalHeaders>\n
   <SignedHeaders>\n
   <HashedPayload>
   ```
   where the last line is hashed payload and this payload has to be matched 
with payload set in the `singatureInfo` object.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to