adoroszlai commented on code in PR #9471:
URL: https://github.com/apache/ozone/pull/9471#discussion_r2611088760
##########
.github/workflows/intermittent-test-check.yml:
##########
@@ -199,7 +203,7 @@ jobs:
export OZONE_REPO_CACHED=true
fi
- args="-DexcludedGroups=native|slow|unhealthy -DskipShade"
+ args="-DexcludedGroups=native|slow|unhealthy -DskipShade ${{
github.event.inputs.maven_additional_args }}"
Review Comment:
```suggestion
args="-DexcludedGroups=slow|unhealthy -DskipShade
-Drocks_tools_native"
```
##########
.github/workflows/intermittent-test-check.yml:
##########
@@ -20,6 +20,10 @@ on:
description: Git Ref (Branch/Commit_ID/Tag)
default: master
required: true
+ maven_additional_args:
+ description: Additional Maven build arguments
+ default: ''
+ required: false
Review Comment:
```suggestion
```
##########
.github/workflows/intermittent-test-check.yml:
##########
@@ -129,7 +133,7 @@ jobs:
java-version: ${{ github.event.inputs.java-version }}
- name: Build (most) of Ozone
run: |
- args="-DskipRecon -DskipShade -Dmaven.javadoc.skip=true"
+ args="-DskipRecon -DskipShade -Dmaven.javadoc.skip=true ${{
github.event.inputs.maven_additional_args }}"
Review Comment:
Instead of the generic "additional args" I'd prefer adding
`-Drocks_tools_native` to match normal `integration` check.
```suggestion
args="-DskipRecon -DskipShade -Dmaven.javadoc.skip=true
-Drocks_tools_native"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
