umamaheswararao commented on a change in pull request #2069:
URL: https://github.com/apache/ozone/pull/2069#discussion_r633694437
##########
File path:
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -179,44 +180,7 @@ public void testIncorrectContainerFile() throws
IOException{
GenericTestUtils.assertExceptionContains("No enum constant", ex);
}
}
-
-
Review comment:
Yes. Let's skip the replicationIndex=0 field writing to yaml file in
this patch.
@avijayanhwx If we bump keyvalueContainer version, does the upgrade
framework handled to check the version numbers?
Currently, as you noticed in this JIRA, we need to write one additional
field in yaml file for EC. Since it's changing the on disk metadata, we need to
worry about compt. While in upgrade in progress, your plan is not to allow new
features to be used right? In that case, if you are already having check for
keyValue container version, then bumping version would make things cleaner.
Could you please comment your thoughts here? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
