adoroszlai commented on code in PR #9486:
URL: https://github.com/apache/ozone/pull/9486#discussion_r2612843491
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCommitRequest.java:
##########
@@ -243,7 +243,7 @@ public void testAtomicRewrite() throws Exception {
OmKeyInfo omKeyInfo = omKeyInfoBuilder.build();
omKeyInfo.appendNewBlocks(allocatedLocationList, false);
List<OzoneAcl> acls =
Collections.singletonList(OzoneAcl.parseAcl("user:foo:rw"));
- omKeyInfo.addAcl(acls.get(0));
+ omKeyInfo = omKeyInfo.toBuilder().addAcl(acls.get(0)).build();
Review Comment:
Please `addAcl` on `omKeyInfoBuilder` before:
https://github.com/apache/ozone/blob/066a51208b5eec6304821fc1a3e524f0b03c66f6/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCommitRequest.java#L243
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/acl/OMKeyAclRequestWithFSO.java:
##########
@@ -99,17 +99,15 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, Execut
omKeyInfo = keyStatus.getKeyInfo();
// Reverting back the full path to key name
// Eg: a/b/c/d/e/file1 -> file1
- omKeyInfo.setKeyName(OzoneFSUtils.getFileName(key));
Review Comment:
nit: Please also move the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
