szetszwo commented on code in PR #9483:
URL: https://github.com/apache/ozone/pull/9483#discussion_r2614919433


##########
pom.xml:
##########
@@ -2384,8 +2384,8 @@
           
<suppressionsLocation>hadoop-hdds/dev-support/checkstyle/suppressions.xml</suppressionsLocation>
           <includeTestSourceDirectory>true</includeTestSourceDirectory>
           <failOnViolation>false</failOnViolation>
-          <format>xml</format>
-          <format>html</format>
+          <outputFormat>xml</outputFormat>
+          <outputFormat>html</outputFormat>

Review Comment:
   It seems that `html` is not supported and the default is `xml`.  So, let's 
remove both lines?
   ```
   % ls -l hadoop-hdds/common/target/checkstyle-*
   -rw-r--r--@ 1 szetszwo  staff  56567 Dec 12 08:46 
hadoop-hdds/common/target/checkstyle-cachefile
   -rw-r--r--@ 1 szetszwo  staff   8959 Dec 12 08:46 
hadoop-hdds/common/target/checkstyle-checker.xml
   -rw-r--r--@ 1 szetszwo  staff  12660 Dec 12 08:46 
hadoop-hdds/common/target/checkstyle-header.txt
   -rw-r--r--@ 1 szetszwo  staff   1331 Dec 12 08:46 
hadoop-hdds/common/target/checkstyle-suppressions.xml
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to