jojochuang commented on code in PR #9409:
URL: https://github.com/apache/ozone/pull/9409#discussion_r2615440974
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdb/util/SstFileSetReader.java:
##########
@@ -71,6 +73,8 @@ public long getEstimatedTotalKeys() throws RocksDBException {
try (ManagedSstFileReader fileReader = new
ManagedSstFileReader(options)) {
fileReader.open(sstFile.toAbsolutePath().toString());
estimatedSize += fileReader.getTableProperties().getNumEntries();
+ } catch (RocksDBException e) {
+ throw new RocksDatabaseException("Failed to open SST file: " +
sstFile, e);
Review Comment:
wrap RocksDBException with RocksDatabaseException because
RocksDatabaseException is an IOException, which simplifies error handle of the
caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
